feat: enhance Treasury and Relay contracts to support new quote token#4
Merged
devmicwal merged 2 commits intoblockydevs:mainfrom Nov 28, 2025
pawell24-blocky-devs:feat/buyback-and-burn
Merged
feat: enhance Treasury and Relay contracts to support new quote token#4devmicwal merged 2 commits intoblockydevs:mainfrom pawell24-blocky-devs:feat/buyback-and-burn
devmicwal merged 2 commits intoblockydevs:mainfrom
pawell24-blocky-devs:feat/buyback-and-burn
Conversation
… and buyback parameters
BartoszSolkaBD
requested changes
Nov 27, 2025
| require(start == tokenToSell, "Treasury: Path start mismatch"); | ||
| require(end == quote, "Treasury: Path must end in quote"); | ||
|
|
||
| IERC20(tokenToSell).forceApprove(address(adapter), 0); |
There was a problem hiding this comment.
is there a need for approval reset? Won't the next line override the approval?
Collaborator
Author
There was a problem hiding this comment.
forceApprove(..., 0) is intentional, some ERC20s (USDT) revert if you change a non-zero allowance without resetting to zero first
| recipient: address(this), | ||
| deadline: deadline, | ||
| amountIn: amountIn, | ||
| amountOut: 0, |
Collaborator
Author
There was a problem hiding this comment.
amountOut: 0 - in exact-in requests is unused, exact-in flows enforce amountOutMinimum. We set it to zero to signal it’s ignored
…DAO_ROLE and improve path validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.