Fix helper tool swap tests: change ssh to https url#76
Open
jakubretajczykBD wants to merge 2 commits intoblockydevs:developfrom
Open
Fix helper tool swap tests: change ssh to https url#76jakubretajczykBD wants to merge 2 commits intoblockydevs:developfrom
jakubretajczykBD wants to merge 2 commits intoblockydevs:developfrom
Conversation
0xMMBD
reviewed
Feb 5, 2026
tests/swap/helper_tool.py
Outdated
Comment on lines
+64
to
+65
| run_cmd('git config --global url."https://github.com/".insteadOf git@github.com:') | ||
| run_cmd('git config --global url."https://github.com/".insteadOf ssh://git@github.com/') |
Member
There was a problem hiding this comment.
to jest na pewno potrzebne jeżeli powyżej zmieniliśmy url na https:?
|
|
||
| base = Path(__file__).parent.resolve() / ".test_dependencies" | ||
|
|
||
| APP_EXCHANGE_URL = "git@github.com:LedgerHQ/app-exchange.git" |
Member
There was a problem hiding this comment.
Podeślij mi jaki problem leciał przed tą zmianą. Potrzebuje mieć jakieś konkrety do opisu, gdzie chce dać:
- Co chciałem zrobić i jaki problem występował
- Co zrobiłem żeby to naprawić
- Jaka jest skala zmian i czy wprowadza ona jakieś ryzyka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
developChange repository URLs from SSH to HTTPS for swap test dependencies
Swap tests were failing in Docker containers because SSH client and keys
are not configured by default. Using HTTPS works out of the box without
any additional setup, making it ideal for ephemeral Docker containers
that are removed after each run.
Changed URLs in helper_tool.py:
Advantages: zero configuration overhead, simpler setup, no SSH key management
Potential drawback: private repos would require auth tokens (same as SSH)