Fix: fix inconsistent arguments types in Storage Tool #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
approved these changes
Jan 27, 2025
Signed-off-by: Dmitrii Petukhov <[email protected]>
bbpetukhov
force-pushed
the
fix-storage-tool-start
branch
from
876c18c to
8786a54
Compare
emelialei88
pushed a commit
to emelialei88/blazingmq
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Dmitrii Petukhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Storage tool crashes on startup because of inconsistent type for cmd line argument "min-records-per-queue":
$ ./build/blazingmq/src/applications/bmqstoragetool/bmqstoragetool.tsk
The type of default value does not match the type specified for the option.
The error occurred while validating the 24th option.
FATAL /home/dpetukhov/projects/bbpetukhov/blazingmq/thirdparty/bde/groups/bal/balcl/balcl_commandline.cpp:1175 Assertion failed: Invalid command line spec
Aborted (core dumped)
Testing performed
Built and made sure Storage tool starts and runs without crash