Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat[bmqtool]: collect ACK latencies #591

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Feat[bmqtool]: collect ACK latencies #591

merged 2 commits into from
Feb 10, 2025
+284 −221

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jan 30, 2025 •
edited
Loading

  • Pass m_bmqtool::Parameters to m_bmqtool::Application as a const-ref, avoid passing and holding it as a pointer.
  • Always put post timestamp to messages in bmqtool. Remove "smart" skipping of messages to add timestamp to.
  • Use throttles to collect in average 1000 latencies per second.
  • Remember post timestamps as correlation ids in producer. Use these ids to calculate ack latencies.

@678098 678098 requested a review from a team as a code owner January 30, 2025 19:05
@678098 678098 force-pushed the 250130_ack_latencies branch 3 times, most recently from 3ddfc67 to 9e43e4e Compare February 3, 2025 16:16
@678098 678098 requested a review from waldgange February 3, 2025 16:45
waldgange
waldgange previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@waldgange waldgange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a concern about the condition in the while loop. Feel free to fix it if it's broken or to merge the PR

@678098 678098 requested a review from waldgange February 7, 2025 15:34
waldgange
waldgange previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@waldgange waldgange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@678098
Feat[bmqtool]: collect ACK latencies
3bddf9e 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098 678098 force-pushed the 250130_ack_latencies branch from af7c542 to 3bddf9e Compare February 10, 2025 12:07
@678098 678098 requested a review from waldgange February 10, 2025 12:07
@678098
Copy link
Collaborator Author

678098 commented Feb 10, 2025

@waldgange rebased

@678098 678098 merged commit fa69fcb into bloomberg:main Feb 10, 2025
25 checks passed
@678098 678098 deleted the 250130_ack_latencies branch February 10, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldgange waldgange

Assignees

@waldgange waldgange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@678098 @waldgange