-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat getting rid of queue creation/deletion cbs #601
base: main
Are you sure you want to change the base?
Conversation
dorjesinpo
commented
Feb 5, 2025
- removing queue creation/deletion cbs
- a step towards converging CSL/legacy
Signed-off-by: dorjesinpo <[email protected]>
de336eb
to
c377025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost made a big blunder, Vitaly :)
removeRecordRaw(recHandles[idx]); | ||
} | ||
} | ||
// In ANY mode, any outstanding QueueOp records are deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove the isCSL
checks at
blazingmq/src/groups/mqb/mqbc/mqbc_storageutil.cpp
Lines 3005 to 3045 in c377025
if (isCSLMode) { | |
const bsls::Types::Int64 numMsgs = rs->numMessages( | |
mqbu::StorageKey::k_NULL_KEY); | |
if (0 != numMsgs) { | |
BMQTSK_ALARMLOG_ALARM("REPLICATION") | |
<< clusterDescription << " Partition [" << partitionId | |
<< "]: Attempt to delete storage for queue [ " << uri | |
<< "], queueKey [" << queueKey << "] which has [" | |
<< numMsgs << "] outstanding messages." | |
<< BMQTSK_ALARMLOG_END; | |
if (status) { | |
*status = rc_QUEUE_HAS_MESSAGES; | |
} | |
return; // RETURN | |
} | |
const mqbs::ReplicatedStorage::RecordHandles& recHandles = | |
rs->queueOpRecordHandles(); | |
for (size_t idx = 0; idx < recHandles.size(); ++idx) { | |
fs->removeRecordRaw(recHandles[idx]); | |
} | |
} | |
BALL_LOG_INFO << clusterDescription << ": Partition [" << partitionId | |
<< "], Deleting storage for queue [" << uri | |
<< "], queueKey [" << queueKey << "] as replica."; | |
fs->unregisterStorage(rs); | |
storageMap->erase(it); | |
if (status) { | |
*status = rc_SUCCESS; | |
} | |
return; // RETURN | |
} | |
// A specific appId is being deleted. | |
if (isCSLMode) { | |
rs->purge(appKey); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2463 of commit c377025 has completed with FAILURE