Skip to content

Conversation

@JerrardSmithOfficial
Copy link

@SparksFullStack

@eddygonzalez9708
Copy link

eddygonzalez9708 commented Jan 11, 2019

Although your Lambda Notes application is not 100% pixel perfect, your application looks great. All the CRUD endpoints work. Also, your code is legible and you did a great job setting up Redux.

These are the following things I will like you to improve or fix:

  1. Work on properly nesting your code statements and writing comments to help other developers understand your code.

  2. I noticed two scroll bars appearing on the home page. One scroll bar is shown for the browser window and one scroll bar is shown for the Note Display component. This is a CSS issue that can be fixed by setting the view width and view height of your root div, App component, and Note Display component.

  3. Rather than displaying the note title and content as placeholders for the input fields in the Note Edit component, the note data should be set to the value attribute of the input fields.

  4. After creating a note, the user should be redirected to the home page or the note view page.

  5. I noticed you used the document object in your code. Since you are using React, you may want to target (e.g. Use the event object) and to control an elements behavior with local state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants