-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initramfs
module
#376
Conversation
…amfs regeneration
@xynydev Just pinging for a review, mostly if not all doc related. |
I'm getting this error when trying to use it
|
Have you installed cliwrap beforehand? It looks like yes. I'll have to add check for this & mark it as unsupported, until Ublue images uncliwrap. |
No, I did that in my own initramfs script, but I'm replacing it with this. Should this module take that into account? |
I marked it as unsupported behavior & I fail the build in F40 & eariler, which required this workaround |
Ah so it's an upstream issue |
@gmpinder can you test again, to see if it will fail in your case now with error message? |
Just remembered that I used this if condition before & that it works, so we covered this scenario too. |
I was just about to say, my script has a check of if [[ ! -f "/usr/libexec/rpm-ostree/wrapped/dracut" ]]; then Could we not just have this check and use that binary if it exists instead of preventing using it? I would think most of our users base their images on Ublue images, so they wouldn't be able to take advantage of this module until upstream removes it. |
Added this just for this transition period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work for me now!
Co-authored-by: xyny <[email protected]>
Co-authored-by: xyny <[email protected]>
Co-authored-by: xyny <[email protected]>
Co-authored-by: xyny <[email protected]>
Co-authored-by: xyny <[email protected]>
@xynydev I merged all suggestions, changed |
Closes: #241