Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initramfs module #376

Merged
merged 29 commits into from
Dec 15, 2024
Merged

feat: initramfs module #376

merged 29 commits into from
Dec 15, 2024

Conversation

fiftydinar
Copy link
Collaborator

@fiftydinar fiftydinar commented Dec 13, 2024

Closes: #241

@fiftydinar fiftydinar requested a review from xynydev as a code owner December 13, 2024 16:02
@fiftydinar
Copy link
Collaborator Author

@xynydev Just pinging for a review, mostly if not all doc related.

@gmpinder
Copy link
Member

I'm getting this error when trying to use it

l/jp-desktop-nvidia:latest => 0.451 integrated with the underlying ostree transaction mechanism.
l/jp-desktop-nvidia:latest => 0.451 Use `rpm-ostree initramfs` to control client-side initramfs generation.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Note: This system is image (rpm-ostree) based.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Continuing execution in 5 seconds.
l/jp-desktop-nvidia:latest => 0.451
l/jp-desktop-nvidia:latest => 5.524 dracut[I]: Executing: /usr/libexec/rpm-ostree/wrapped/dracut --no-hostonly --kver 6.11.10-304.bazzite.fc41.x86_64 --reproducible -v --add ostree -f /usr/lib/modules/6.11.10-304.bazzite.fc41.x86_64/initramfs.img
l/jp-desktop-nvidia:latest => 5.952 dracut[F]: No permission to write to /usr/lib/modules/6.11.10-304.bazzite.fc41.x86_64.
l/jp-desktop-nvidia:latest => 5.955 ========================== Failed 'initramfs' Module ==========================

@fiftydinar
Copy link
Collaborator Author

fiftydinar commented Dec 13, 2024

I'm getting this error when trying to use it

l/jp-desktop-nvidia:latest => 0.451 integrated with the underlying ostree transaction mechanism.
l/jp-desktop-nvidia:latest => 0.451 Use `rpm-ostree initramfs` to control client-side initramfs generation.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Note: This system is image (rpm-ostree) based.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`.
l/jp-desktop-nvidia:latest => 0.451 rpm-ostree: Continuing execution in 5 seconds.
l/jp-desktop-nvidia:latest => 0.451
l/jp-desktop-nvidia:latest => 5.524 dracut[I]: Executing: /usr/libexec/rpm-ostree/wrapped/dracut --no-hostonly --kver 6.11.10-304.bazzite.fc41.x86_64 --reproducible -v --add ostree -f /usr/lib/modules/6.11.10-304.bazzite.fc41.x86_64/initramfs.img
l/jp-desktop-nvidia:latest => 5.952 dracut[F]: No permission to write to /usr/lib/modules/6.11.10-304.bazzite.fc41.x86_64.
l/jp-desktop-nvidia:latest => 5.955 ========================== Failed 'initramfs' Module ==========================

Have you installed cliwrap beforehand?

It looks like yes.

I'll have to add check for this & mark it as unsupported, until Ublue images uncliwrap.

@gmpinder
Copy link
Member

gmpinder commented Dec 13, 2024

Have you installed cliwrap beforehand?

No, I did that in my own initramfs script, but I'm replacing it with this. Should this module take that into account?

@fiftydinar
Copy link
Collaborator Author

Have you installed cliwrap beforehand?

No, I did that in my own initramfs script, but I'm replacing it with this. Should this module take that into account?

I marked it as unsupported behavior & I fail the build in F40 & eariler, which required this workaround

@gmpinder
Copy link
Member

It looks like yes.

I'll have to add check for this & mark it as unsupported, until Ublue images uncliwrap.

Ah so it's an upstream issue

@fiftydinar
Copy link
Collaborator Author

fiftydinar commented Dec 13, 2024

@gmpinder can you test again, to see if it will fail in your case now with error message?

@fiftydinar
Copy link
Collaborator Author

@gmpinder can you test again, to see if it will fail in your case now with error message?

Just remembered that I used this if condition before & that it works, so we covered this scenario too.

@gmpinder
Copy link
Member

gmpinder commented Dec 13, 2024

@gmpinder can you test again, to see if it will fail in your case now with error message?

Just remembered that I used this if condition before & that it works, so we covered this scenario too.

I was just about to say, my script has a check of

if [[ ! -f "/usr/libexec/rpm-ostree/wrapped/dracut" ]]; then

Could we not just have this check and use that binary if it exists instead of preventing using it? I would think most of our users base their images on Ublue images, so they wouldn't be able to take advantage of this module until upstream removes it.

@fiftydinar
Copy link
Collaborator Author

Could we not just have this check and use that binary if it exists instead of preventing using it? I would think most of our users base their images on Ublue images, so they wouldn't be able to take advantage of this module until upstream removes it.

Added this just for this transition period.

gmpinder
gmpinder previously approved these changes Dec 13, 2024
Copy link
Member

@gmpinder gmpinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me now!

gmpinder
gmpinder previously approved these changes Dec 14, 2024
@fiftydinar
Copy link
Collaborator Author

fiftydinar commented Dec 15, 2024

@xynydev I merged all suggestions, changed ram to RAM in docs, indicated early Linux startup process for initramfs definition & updated the description to shorter one, with retained meaning.

@fiftydinar fiftydinar merged commit 23e3611 into main Dec 15, 2024
5 checks passed
@fiftydinar fiftydinar deleted the feat-initramfs branch December 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: initramfs module
4 participants