fix: update TypeScript init scaffold for ESM tooling#81
Open
beeman wants to merge 1 commit intoblueshift-gg:masterfrom
Open
fix: update TypeScript init scaffold for ESM tooling#81beeman wants to merge 1 commit intoblueshift-gg:masterfrom
beeman wants to merge 1 commit intoblueshift-gg:masterfrom
Conversation
Generate ESM package metadata and a typecheck script for TypeScript test projects. Also switch the generated tsconfig to bundler-style module resolution and refresh the Node and Vitest dev dependency versions.
beeman
commented
Mar 24, 2026
Comment on lines
+80
to
+85
| "module": "preserve", | ||
| "moduleResolution": "bundler", | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "target": "ESNext", |
Contributor
Author
There was a problem hiding this comment.
These are modern settings that fix the error in the screenshot, and make TypeScript convenient to work with (no need to use .js/.ts for imports, for example).
| }}, | ||
| "devDependencies": {{ | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^22.13.0", |
Contributor
Author
There was a problem hiding this comment.
This version of Node stabilized the WebCrypto api.
| "@types/node": "^22.13.0", | ||
| "typescript": "^5.9.3", | ||
| "vitest": "^3.1.0" | ||
| "vitest": "^4.1.1" |
Contributor
Author
There was a problem hiding this comment.
Let's use the latest version
| "private": true, | ||
| "type": "module", | ||
| "scripts": {{ | ||
| "check-types": "tsc --noEmit", |
Contributor
Author
There was a problem hiding this comment.
Having quick access to a type check is useful, it helps find issues like the one fixed in #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate ESM package metadata and a typecheck script for TypeScript test projects.
Also switch the generated tsconfig to bundler-style module resolution and refresh the Node and Vitest dev dependency versions.