✨ Add people tab on search page #247
Merged
+153
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
add-people-search-tab - ozone-staging PR #247
Render
Destroyed
matthieusieben
approved these changes
Nov 24, 2024
| queryKey: ['searchContent', { term, section }], | ||
| enabled: !!term, | ||
| queryFn: async ({ pageParam }) => { | ||
| if (section === 'people') { | ||
| // This is actually never hit, we always have appview configured | ||
| if (!appviewAgent) { |
There was a problem hiding this comment.
Can this really be null?!
There was a problem hiding this comment.
nope. mostly for bypassing the ts check. technically, without appview url configured, it can be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Peopletab on the search page similar to the app's search page which shows all users matching the search query.