✨ Paginate events when adding to workspace #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // if the modal is closed, that means the user decided not to add any more user to workspace | ||
| } while (cursor && showWorkspaceConfirmation) | ||
| } catch (e) { | ||
| if (abortController.current?.signal.reason === 'user-cancelled') { |
There was a problem hiding this comment.
You can also use the aborted property, which is the more common way of checking if a signal was aborted.
Suggested change
| if (abortController.current?.signal.reason === 'user-cancelled') { | |
| if (abortController.current?.signal.aborted) { |
| } | ||
| useEffect(() => { | ||
| if (!showWorkspaceConfirmation) { | ||
| abortController.current?.abort('user-cancelled') |
There was a problem hiding this comment.
Only Error instances should ever be used as abort reason. This is otherwise similar to throw "some string". Note that you can do ac.abort() (no argument).
matthieusieben
approved these changes
Feb 4, 2025
arcalinea
temporarily deployed
to
paginate-events-to-workspace - ozone-staging PR #284
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.