Ozone frontend/backend build and account setup #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://ozone-staging-pr-35.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnnio1mct0pc739tmk90. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-35.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnnio26ct0pc739tmki0. |
foysalit
reviewed
Mar 11, 2024
| const [session, setSession] = useState( | ||
| client.authState === AuthState.LoggedOut ? null : client.session, | ||
| ) | ||
| useEffect(() => { |
There was a problem hiding this comment.
do we want this to re-run on every render or just when client.session changes? just being cautious so that we don't run unnecessary things on every render since there are no deps on this useEffect
foysalit
approved these changes
Mar 11, 2024
foysalit
reviewed
Mar 11, 2024
devinivy
added a commit
that referenced
this pull request
Mar 14, 2024
* Ozone frontend/backend build and account setup (#35) * setup dockerfile and service entrypoint for frontend/backend deployed together * gitignore/yarnlock tidy * auth state for ozone configuration * update api package * plc/identity setup workflow * tidy/fixes * record creation flow on login * reorg client config / configuration flow * skip record creation step if not service account * tidy * rename metadata endpoint * fix * reorg plc constants, bring plc functionality into lib/identity * make generic ErrorInfo component * misc fixes * fix cypress * websocket fix * add docker workflow * update ozone version * fix entrypoint order of operations * fix next build / rel paths --------- Co-authored-by: Foysal Ahamed <[email protected]> * Docs on hosting ozone UI and backend (#48) * setup dockerfile and service entrypoint for frontend/backend deployed together * gitignore/yarnlock tidy * auth state for ozone configuration * update api package * plc/identity setup workflow * tidy/fixes * record creation flow on login * reorg client config / configuration flow * skip record creation step if not service account * tidy * rename metadata endpoint * fix * reorg plc constants, bring plc functionality into lib/identity * make generic ErrorInfo component * misc fixes * fix cypress * websocket fix * docs on hosting ozone ui and backend * minor tweaks * minor tweaks * add docker workflow * update ozone version * misc doc fixes * fix entrypoint order of operations * fix next build / rel paths * fix old ozone-ui references * fix markdown table * use a working build sha in compose * fix headers --------- Co-authored-by: Jake Gold <[email protected]> Co-authored-by: Foysal Ahamed <[email protected]> * Show custom labels from labeler service in ozone (#51) * setup dockerfile and service entrypoint for frontend/backend deployed together * gitignore/yarnlock tidy * auth state for ozone configuration * update api package * plc/identity setup workflow * tidy/fixes * record creation flow on login * reorg client config / configuration flow * skip record creation step if not service account * tidy * rename metadata endpoint * fix * reorg plc constants, bring plc functionality into lib/identity * make generic ErrorInfo component * misc fixes * fix cypress * websocket fix * add docker workflow * update ozone version * ✨ Use custom labeler labels in label input --------- Co-authored-by: Devin Ivy <[email protected]> * Service record configuration (#52) * setup dockerfile and service entrypoint for frontend/backend deployed together * gitignore/yarnlock tidy * auth state for ozone configuration * update api package * plc/identity setup workflow * tidy/fixes * record creation flow on login * reorg client config / configuration flow * skip record creation step if not service account * tidy * rename metadata endpoint * fix * reorg plc constants, bring plc functionality into lib/identity * make generic ErrorInfo component * misc fixes * fix cypress * websocket fix * boilerplate for service account configuration page * in-progess, configuration page * in-progess, configuration page * minor reorg in configure page * add react-json-view dep for record config * record configuration flow * fix dep * tidy * browser-only react viewer * build 0.1.0 rc * final tidy * ozone version bump * build * tidy --------- Co-authored-by: Foysal Ahamed <[email protected]> Co-authored-by: Jake Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things going on here. First, the
service/entrypoint has been added in order to support an Ozone frontend and backend running together. The Dockerfile has been updated to run this service entrpoint. The Ozone backend serves a metadata endpoint with its DID, URL, and public key, which the UI uses in order to configure the service account's (i.e. account with the same DID) identity and publish theirapp.bsky.labeler.servicerecord.If the service account does not have a labeler service endpoint and key, then the UI requires that you login as the service account and configure it. Without a service endpoint, there's no way for the PDS to properly proxy to the service.
Publishing the service record is optional. Each time the service account logs in, it prompts them to publish the record and they may opt to skip.
A couple things to look out for here. We want to ensure this works just fine for our Ozone deployment, where the frontend and backend are not on the same domain. I set it up to work like this, but haven't been able to test it yet. I have also updated the
sessionobject, which gets stored in local storage, so there may be a compatibility issue there to check out. Lastly, there could be some issues that we could provide better error messages for, such as handling the case that he backend is offline; the service can't be found due to use of a different PLC environment; etc. I did add a new config optionNEXT_PUBLIC_PLC_DIRECTORY_URLwhich defaults to prod PLC. We may set this in our staging environment.