Skip to content

[APP-3658] Fix reopening long alt text scrolling the sheet offscreen on iOS #12196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mozzius wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[APP-3658] Fix reopening long alt text scrolling the sheet offscreen on iOS #12196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion modules/bottom-sheet/src/BottomSheetNativeComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,20 @@ function BottomSheetNativeComponentInner({
* Without them an unsized absolute view shrinks to fit its content, which
* squeezes `flex: 1` rows down to their icons (APP-3602). The state size
* still wins, since a defined width takes precedence over the insets.
*
* A full-height sheet on iOS gets `top` and `bottom` too, for the same
* reason vertically. If its first layout shrinks to fit, Yoga keeps each
* `flex: 1` wrapper's content height as its flex basis and never shrinks
* it to the canvas that lands later
* (https://github.com/facebook/yoga/issues/2019). Tall content then
* overflows the sheet as it's presented, and an autofocused input raises
* the keyboard against that frame (APP-3658).
*/
style={{position: 'absolute', left: 0, right: 0}}
style={[
{position: 'absolute', left: 0, right: 0},
Platform.OS === 'ios' &&
rest.fullHeight === true && {top: 0, bottom: 0},
]}
containerBackgroundColor={nativeContainerBackgroundColor}>
<View
style={[
Expand Down
Loading