Enable lightbox animation for avis, make them rounded #6081
+181
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Nov 2, 2024
|
|
||
| const onPressAvi = React.useCallback(() => { | ||
| if ( | ||
| avatar // TODO && !(view.moderation.avatar.blur && view.moderation.avatar.noOverride) |
There was a problem hiding this comment.
this isn't new, i just moved it from above. i don't have context on this todo
|
It looks like after all I do want to fork based on those.
gaearon
force-pushed
the
images-avatars
branch
from
d7e35b1
to
01b3501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #6047, #6073, and #6048
Extends #6048 to opening profile avatars. While at it, I've also made the lightbox display them as circles (or rounded rects for feeds/SPs) and limited displayed size on the web so they don't blow up.
Review without spaces
Known Issues
Test Plan
pic_ios.mov
android.mov
Screen.Recording.2024-11-02.at.15.14.34.mov
Verify normal lightbox (regular images) still works too.