Create CLI name variables in new locals mapping #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
approved these changes
Jun 9, 2025
Should already have been fixed by #166 |
In 3.13 the behaviour of the locals builtin changed so that modifications no longer had any affect in certain situations. This meant the plot CLI subcommand would raise NameError for single letter axis names as used in the cli tests. Passing the locals as a new mapping allows the same code to work with both the new and old locals behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.13 the behaviour of the locals builtin changed so that
modifications no longer had any affect in certain situations. This meant
the plot CLI subcommand would raise NameError for single letter axis
names as used in the cli tests.
Passing the locals as a new mapping allows the same code to work with
both the new and old locals behaviour.
Fixes #163
Instructions to reviewer on how to test:
uv run --extra dev --python 3.13 pytest)Checks for reviewer