Skip to content

fix(accesibility): use rem for font sizes ((WCAG 1.4.4) — issue #1024) #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(accesibility): use rem for font sizes ((WCAG 1.4.4) — issue #1024) #2946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
530889a
fix(accesibility): use rem for font sizes ((WCAG 1.4.4) — issue #1024)
IsraelMancha Sep 11, 2025
3ead43a
Remove unintended package changes
IsraelMancha Sep 11, 2025
a310c60
corrected comment
IsraelMancha Sep 11, 2025
17452ab
correction to original semantic variable
IsraelMancha Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 286 additions & 36 deletions client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-react-refresh": "^0.4.6",
"prettier": "^3.3.3",
"rollup": "^4.50.1",
Copy link

@llamapreview llamapreview bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: High

The addition of the Rollup dependency is unrelated to the stated goal of converting font sizes to rem units. This introduces unnecessary bloat and maintenance overhead for a PR focused solely on accessibility improvements.

Suggested change
"rollup": "^4.50.1",
Remove this line as it's unrelated to the PR's objective.

Copy link
Collaborator

@ajhollid ajhollid Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, please do remove

Copy link
Author

@IsraelMancha IsraelMancha Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I work now

"vite": "6.3.5"
}
}
Loading