-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/Icons refactoring #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you have tested each icon, I am approving these changes. But I will not merge the PR, so you can keep working on the same branch.
@SepidehShahbazi once you have a PR with a visual change, could you send images/videos supporting your work? This will also help me understand what has changed overall. Thanks! |
Also, If possible it's better to create the PR with UI changes for better readability, It would let reviewers know about the exact changes in UI. UI Changes OverviewBeforeAfterSummary of Changes
|
There are no UI changes in this PR as this is just a refactoring of the icons. |
Got it, thanks! |
@gorkem-bwl as @mahid797 has mentioned, in this case we don't have any UI changes. It's about refactoring Icons and converting them to React components instead of .svg, which triggers the icons to be reusable, flexible and easier for using, but during implementing this PR for other icons if there are some icons that are not match with the Figma icons and I change them, which causes the UI to be changed, I'll add photos/videos in the PR. |
@parwatcodes it's a good idea. From now on, I can apply it for PRs, which have UI changes. |
That's my bad. I mistakenly thought "refactoring" somehow meant new icons :-D Normally that doesn't happen. I'll be more careful next time. |
No worries at all ^_^. I appreciate you taking the time to check it thoroughly. Let me know if there's anything else you'd like adjusted or clarified. |
Completed the refactoring of documentPage icons for issue #50.