Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Species types #94

Closed
wants to merge 8 commits into from
Closed

Species types #94

wants to merge 8 commits into from

Conversation

rot4te
Copy link
Collaborator

@rot4te rot4te commented Oct 23, 2024

Changed the types of Species fields to unitful numbers, eg charge::typeof(1u"q") and mass_in_eV::typeof(1.0u"eV/c^2")

mattsignorelli
mattsignorelli requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mattsignorelli mattsignorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments near mass and charge, those functions need minor changes and removal of the unnecessary unit conversion of Species for default constructor

@mattsignorelli
Copy link
Contributor

@lllx125 implemented massof, chargeof, and setunits all correct, and is merging into main momentarily. However his Species struct still has non-unitful quantities. Could you pull the latest main and resolve the merge conflicts?

@rot4te rot4te closed this Nov 6, 2024
@rot4te rot4te deleted the species_types branch November 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsignorelli mattsignorelli mattsignorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rot4te @mattsignorelli