Open
Conversation
Signed-off-by: Matt Evans <[email protected]>
tcitworld
reviewed
Aug 21, 2025
| if (isO365Url($url)) { | ||
| // 2025/08/20 - the required format/values here are not documented; this string based on research | ||
| // from: https://github.com/bitfireAT/icsx5/discussions/654#discussioncomment-14158051 | ||
| $uaString = 'NextCloud/30.x (Linux Android 16) like Chrome/30'; |
There was a problem hiding this comment.
Is a number for the Nextcloud version required or does it work without it? If it's required, it would be more appropriate to provide the actual Nextcloud version.
Owner
Author
There was a problem hiding this comment.
It turns out Nextcloud Version is not required. The easiest thing is to omit it.
If there is a method which holds the version string and is easy to plumb in here, I could Include it. Do you know of something appropriate?
There was a problem hiding this comment.
There's a OCP\ServerVersion class that provides all that you need, but I think you shouldn't include if it's not required.
in testing: NC version not needed "Linux" not needed in comment - "Android" needed within comment - a version number after Android is needed Signed-off-by: Matt Evans <[email protected]>
Signed-off-by: Matt Evans <[email protected]>
Signed-off-by: Matt Evans <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist