Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent margin clicks from going to the parent node #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cimugbit
Copy link

Thank you for this great library! When using version 1.2.9 of it I noted that clicks in the indentation area of child nodes go to the parent node, normally collapsing it. I found this behavior not correct, so in commit 68a5d1c I changed the code to attach the handlers to the nodeView instead of the nodeWrapperView. I found it easiest to achieve this by using two additional methods in BaseNodeViewHolder, but there might be better ways to achieve the same result.

In my second commit ac5b9a7 I corrected a typo in one of your method names. Feel free to ignore it if it breaks compatibility with existing code too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant