Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show rule option list "Default" column even with only a falsy value #483

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Show rule option list "Default" column even with only a falsy value #483

merged 1 commit into from
Oct 13, 2023

Conversation

bmish
Copy link
Owner

@bmish bmish commented Oct 13, 2023

Knowing that false is the default for a rule option is valuable so we should still display the "Default" column when that information is available. Example:

Name Default
foo false

@bmish bmish added the bug Something isn't working label Oct 13, 2023
@bmish bmish requested a review from ddzz October 13, 2023 20:08
@bmish bmish merged commit 7c07cae into main Oct 13, 2023
6 of 9 checks passed
@bmish bmish deleted the default-falsy-rule-option-list-col branch October 13, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddzz ddzz ddzz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmish @ddzz