Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest: Rename deprecated ...TEST_CASE API #160

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

yannik-dittmar
Copy link
Collaborator

With version 1.10.0 gtest renames its ...TEST_CASE methods to ...TEST_SUITE.
(https://github.com/google/googletest/releases/tag/release-1.10.0)

This commit adapts the new naming, it replaces all INSTANTIATE_TEST_CASE_P in favor of INSTANTIATE_TEST_SUITE_P and uses the find_package methode in the CMake file to find the gtest lib on the system.

With version 1.10.0 gtest renames its ...TEST_CASE methods to
...TEST_SUITE.
(https://github.com/google/googletest/releases/tag/release-1.10.0)

This commit adapts the new naming, it replaces all
INSTANTIATE_TEST_CASE_P in favor of INSTANTIATE_TEST_SUITE_P and
uses the find_package methode in the CMake file to find the gtest
lib on the system.
@yannik-dittmar
Copy link
Collaborator Author

All tests are passing.

$ ctest . --output-on-failure
Test project /src/build
      Start  1: OpenSSLTest
 1/31 Test  #1: OpenSSLTest ......................   Passed    0.00 sec
      Start  2: Asn1TimeTests
 2/31 Test  #2: Asn1TimeTests ....................   Passed    0.00 sec
      Start  3: HashTests
 3/31 Test  #3: HashTests ........................   Passed    0.00 sec
      Start  4: UtilTests
 4/31 Test  #4: UtilTests ........................   Passed    0.00 sec
      Start  5: KeyTest
 5/31 Test  #5: KeyTest ..........................   Passed    5.87 sec
      Start  6: CsrTests
 6/31 Test  #6: CsrTests .........................   Passed    0.16 sec
      Start  7: BioTests
 7/31 Test  #7: BioTests .........................   Passed    0.00 sec
      Start  8: DistinguishedNameTests
 8/31 Test  #8: DistinguishedNameTests ...........   Passed    0.00 sec
      Start  9: X509Tests
 9/31 Test  #9: X509Tests ........................   Passed    0.07 sec
      Start 10: CRLTests
10/31 Test #10: CRLTests .........................   Passed    0.01 sec
      Start 11: VerificationTests
11/31 Test #11: VerificationTests ................   Passed    0.18 sec
      Start 12: CATests
12/31 Test #12: CATests ..........................   Passed    5.09 sec
      Start 13: SignatureTests
13/31 Test #13: SignatureTests ...................   Passed    0.15 sec
      Start 14: AsymEncryptionTests
14/31 Test #14: AsymEncryptionTests ..............   Passed    0.01 sec
      Start 15: RSAPaddingModeTests
15/31 Test #15: RSAPaddingModeTests ..............   Passed    0.07 sec
      Start 16: SymmetricCipherTest
16/31 Test #16: SymmetricCipherTest ..............   Passed    0.02 sec
      Start 17: SymmetricCipherMemoryModelTest
17/31 Test #17: SymmetricCipherMemoryModelTest ...   Passed    0.00 sec
      Start 18: KdfSchemesTest
18/31 Test #18: KdfSchemesTest ...................   Passed    0.01 sec
      Start 19: HMacSchemesTest
19/31 Test #19: HMacSchemesTest ..................   Passed    0.00 sec
      Start 20: CMacSchemesTest
20/31 Test #20: CMacSchemesTest ..................   Passed    0.00 sec
      Start 21: EciesSchemesTest
21/31 Test #21: EciesSchemesTest .................   Passed    0.02 sec
      Start 22: aesExample
22/31 Test #22: aesExample .......................   Passed    0.00 sec
      Start 23: caCsrExample
23/31 Test #23: caCsrExample .....................   Passed    0.01 sec
      Start 24: eciesExample
24/31 Test #24: eciesExample .....................   Passed    0.01 sec
      Start 25: hashExample
25/31 Test #25: hashExample ......................   Passed    0.00 sec
      Start 26: kdfExample
26/31 Test #26: kdfExample .......................   Passed    0.01 sec
      Start 27: keyExample
27/31 Test #27: keyExample .......................   Passed    0.11 sec
      Start 28: macExample
28/31 Test #28: macExample .......................   Passed    0.00 sec
      Start 29: rsaExample
29/31 Test #29: rsaExample .......................   Passed    0.19 sec
      Start 30: sigExample
30/31 Test #30: sigExample .......................   Passed    0.16 sec
      Start 31: certValidation
31/31 Test #31: certValidation ...................   Passed    0.00 sec

100% tests passed, 0 tests failed out of 31

For find_package(GTest) to work CMake requires the -dev variants of the
gtest and gmock package.
This commit installs the required packages in our base image.
@istepic istepic merged commit 16c686d into bmwcarit:openssl3 Dec 5, 2023
18 checks passed
@yannik-dittmar yannik-dittmar deleted the rename-deprecated-gtest branch December 5, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants