-
Notifications
You must be signed in to change notification settings - Fork 1
chore: trim tokio features and update httpmock #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @bniladridas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on optimizing the project's dependency management by trimming unnecessary features from the Tokio runtime and upgrading the httpmock testing framework. The primary goal is to reduce compile times, minimize the runtime footprint, and improve maintainability without introducing any changes to the existing runtime behavior. These changes result in a more efficient and streamlined build environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
HarperBot AnalysisSummaryThis pull request significantly refactors the project's asynchronous runtime, migrating away from the Scores
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes some great dependency optimizations. Trimming the tokio features is an excellent move to reduce bloat and improve compile times. The update to httpmock is also good for keeping dependencies current.
I noticed that httpmock appears to be an unused development dependency. Removing it would further streamline the dependency graph, which aligns perfectly with the goals of this PR. I've added a specific comment about this in Cargo.toml.
With that one change, this PR will be a solid improvement.
| [dev-dependencies] | ||
| httpmock = "0.7" | ||
| httpmock = "0.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
httpmock is listed as a dev-dependency and is being updated here. However, after reviewing the test files (tests/e2e.rs, tests/integration.rs) and in-file test modules, I couldn't find any usage of it.
If this dependency is indeed unused, removing it would be a great way to further reduce dependency bloat and simplify the dependency tree, which is one of the main goals of this PR. If it's intended for future use, perhaps a basic test case could be added to justify its inclusion.
HarperBot AnalysisSummaryThis pull request represents a significant refactoring, migrating the Scores
Strengths
|
This update trims dependency bloat by narrowing the Tokio feature set to only what the project actually needs—rt-multi-thread and macros. This reduces compile times, lowers transitive dependencies, and keeps the runtime footprint focused.
We also upgraded httpmock to version 0.8, aligning the test stack with its latest API changes and improving long-term compatibility. The update required small adjustments in test setup but keeps the suite stable.
Together, these changes streamline the dependency graph, improve maintainability, and keep the build faster and cleaner without altering any runtime behavior.