Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced asterix import by targeted list #147

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

RobertoRoos
Copy link
Contributor

This seems to already fix most of the auto-complete issues (#145 ):
image

However, the doc strings aren't shown yet, which would also be expected.

@bnjmnp bnjmnp merged commit 585e3cb into bnjmnp:master Jul 7, 2024
@bnjmnp
Copy link
Owner

bnjmnp commented Jul 7, 2024

I liked this and so already merged it, but I'm not completely convinced of how the ec_datatype is handled.
Up till now I could do this

    assert obj_0x1000.data_type == pysoem.ECT_UNSIGNED32

and now need to do this:

    assert obj_0x1000.data_type == pysoem.ec_datatype.ECT_UNSIGNED32

Which is okay in general, to not spoil the whole pysoem namespace, but this still misses auto-completion and I rather like to rename ec_datatype to just DataType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants