Migrate Duration to smallest numeric types possible for efficiency

Cargo.toml

@@ -75,6 +75,7 @@ timezone_provider = { workspace = true, optional = true}
 # System time feature
 web-time = { workspace = true, optional =  true }
 iana-time-zone = { workspace = true, optional = true }
+bnum = "0.13.0"
 
 [features]
 default = ["sys"]

depcheck/src/main.rs

@@ -174,6 +174,7 @@ pub const BASIC_RUNTIME_DEPS: &[&str] = &[
     "zerotrie",
     "zerovec",
     // Other deps
+    "bnum",
     "libm",
     "num-traits",
     "stable_deref_trait",

src/builtins/compiled/duration/tests.rs

@@ -3,7 +3,7 @@ use crate::{
         OffsetDisambiguation, RelativeTo, RoundingIncrement, RoundingMode, RoundingOptions, Unit,
     },
     partial::PartialDuration,
-    Calendar, DateDuration, PlainDate, TimeDuration, TimeZone, ZonedDateTime,
+    Calendar, DateDuration, PlainDate, TimeZone, ZonedDateTime,
 };
 
 use core::{num::NonZeroU32, str::FromStr};
@@ -373,7 +373,20 @@ fn basic_negative_expand_rounding() {
 
 #[test]
 fn rounding_to_fractional_day_tests() {
-    let twenty_five_hours = Duration::from(TimeDuration::new(25, 0, 0, 0, 0, 0).unwrap());
+    let twenty_five_hours = Duration::new_unchecked(
+        Default::default(),
+        0,
+        0,
+        0,
+        0u8.into(),
+        25u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+    );
+
     let options = RoundingOptions {
         largest_unit: Some(Unit::Day),
         smallest_unit: None,
@@ -485,7 +498,19 @@ fn basic_subtract_duration() {
 // days-24-hours-relative-to-zoned-date-time.js
 #[test]
 fn round_relative_to_zoned_datetime() {
-    let duration = Duration::from(TimeDuration::new(25, 0, 0, 0, 0, 0).unwrap());
+    let duration = Duration::new_unchecked(
+        Default::default(),
+        0,
+        0,
+        0,
+        0u8.into(),
+        25u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+        0u8.into(),
+    );
     let zdt = ZonedDateTime::try_new(
         1_000_000_000_000_000_000,
         Calendar::default(),

src/builtins/core/calendar.rs

@@ -4,14 +4,11 @@
 //! Temporal compatible calendar implementations.
 
 use crate::{
-    builtins::core::{
-        duration::{DateDuration, TimeDuration},
-        Duration, PlainDate, PlainDateTime, PlainMonthDay, PlainYearMonth,
-    },
+    builtins::core::{Duration, PlainDate, PlainDateTime, PlainMonthDay, PlainYearMonth},
     iso::IsoDate,
     options::{ArithmeticOverflow, Unit},
     parsers::parse_allowed_calendar_formats,
-    TemporalError, TemporalResult,
+    DateDuration, TemporalError, TemporalResult,
 };
 use alloc::string::ToString;
 use core::str::FromStr;
@@ -300,7 +297,7 @@ impl Calendar {
             // duration.[[Milliseconds]], duration.[[Microseconds]], duration.[[Nanoseconds]]).
             // 9. Let balanceResult be BalanceTimeDuration(norm, "day").
             let (balance_days, _) =
-                TimeDuration::from_normalized(duration.time().to_normalized(), Unit::Day)?;
+                Duration::from_normalized_time(duration.to_normalized(), Unit::Day)?;
 
             // 10. Let result be ? AddISODate(date.[[ISOYear]], date.[[ISOMonth]], date.[[ISODay]], duration.[[Years]],
             // duration.[[Months]], duration.[[Weeks]], duration.[[Days]] + balanceResult.[[Days]], overflow).

src/builtins/core/date.rs

@@ -20,8 +20,7 @@ use icu_calendar::AnyCalendarKind;
 use writeable::Writeable;
 
 use super::{
-    calendar::month_to_month_code,
-    duration::{normalized::NormalizedDurationRecord, TimeDuration},
+    calendar::month_to_month_code, duration::normalized::NormalizedDurationRecord,
     PartialYearMonth, PlainMonthDay, PlainYearMonth,
 };
 use tinystr::TinyAsciiStr;
@@ -206,9 +205,7 @@ impl PlainDate {
         //    "day").[[Days]].
         let days = duration
             .days()
-            .checked_add(
-                TimeDuration::from_normalized(duration.time().to_normalized(), Unit::Day)?.0,
-            )
+            .checked_add(Duration::from_normalized_time(duration.to_normalized(), Unit::Day)?.0)
             .ok_or(TemporalError::range())?;
 
         // 7. Let result be ? AddISODate(plainDate.[[ISOYear]], plainDate.[[ISOMonth]], plainDate.[[ISODay]], 0, 0, 0, days, overflow).
@@ -288,7 +285,7 @@ impl PlainDate {
         let result = self.internal_diff_date(other, resolved.largest_unit)?;
 
         // 10. Let duration be ! CreateNormalizedDurationRecord(result.[[Years]], result.[[Months]], result.[[Weeks]], result.[[Days]], ZeroTimeDuration()).
-        let mut duration = NormalizedDurationRecord::from_date_duration(*result.date())?;
+        let mut duration = NormalizedDurationRecord::from_date_duration(result.date())?;
         // 11. If settings.[[SmallestUnit]] is "day" and settings.[[RoundingIncrement]] = 1, let roundingGranularityIsNoop be true; else let roundingGranularityIsNoop be false.
         let rounding_granularity_is_noop =
             resolved.smallest_unit == Unit::Day && resolved.increment.get() == 1;

src/builtins/core/datetime.rs

@@ -118,13 +118,16 @@ impl PlainDateTime {
         // 4. Let calendarRec be ? CreateCalendarMethodsRecord(dateTime.[[Calendar]], « date-add »).
 
         // 5. Let norm be NormalizeTimeDuration(sign × duration.[[Hours]], sign × duration.[[Minutes]], sign × duration.[[Seconds]], sign × duration.[[Milliseconds]], sign × duration.[[Microseconds]], sign × duration.[[Nanoseconds]]).
-        let norm = NormalizedTimeDuration::from_time_duration(duration.time());
+        let norm = NormalizedTimeDuration::from_duration(duration);
 
         // TODO: validate Constrain is default with all the recent changes.
         // 6. Let result be ? AddDateTime(dateTime.[[ISOYear]], dateTime.[[ISOMonth]], dateTime.[[ISODay]], dateTime.[[ISOHour]], dateTime.[[ISOMinute]], dateTime.[[ISOSecond]], dateTime.[[ISOMillisecond]], dateTime.[[ISOMicrosecond]], dateTime.[[ISONanosecond]], calendarRec, sign × duration.[[Years]], sign × duration.[[Months]], sign × duration.[[Weeks]], sign × duration.[[Days]], norm, options).
-        let result =
-            self.iso
-                .add_date_duration(self.calendar().clone(), duration.date(), norm, overflow)?;
+        let result = self.iso.add_date_duration(
+            self.calendar().clone(),
+            &duration.date(),
+            norm,
+            overflow,
+        )?;
 
         // 7. Assert: IsValidISODate(result.[[Year]], result.[[Month]], result.[[Day]]) is true.
         // 8. Assert: IsValidTime(result.[[Hour]], result.[[Minute]], result.[[Second]], result.[[Millisecond]],