Glcanvas #69
Merged
Glcanvas #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
reviewed
Oct 12, 2024
Comment on lines
+49
to
+55
| ${scripts} | ||
| ${viewerScript} | ||
| </body>` : ` | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| ${scripts} | ||
| ${viewerScript} |
There was a problem hiding this comment.
Scripts are added twice, inside body and head, this can have side-effects for other games
There was a problem hiding this comment.
Have you seen the ? : expression?
| </div> | ||
| </body> | ||
| <body> | ||
| <canvas id='glcanvas' style="margin: 0; padding: 0; width: 100%; height: 100%; overflow: hidden; position: absolute; z-index: 0;"></canvas> |
There was a problem hiding this comment.
This is specific to clash, for other games it would add a full-screen canvas
In the viewer for clash, you can add this directly with body.append(...) in the JS, in a synchronous manner
There was a problem hiding this comment.
This is only in the clash special logic
coyotte508
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.