6 prices update - #262
Conversation
WalkthroughUpdated product pricing and some gallery entries in product data, removed three products from the public products export, corrected two i18n strings (meta and Ukrainian delivery text), and adjusted a local Props type and the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Browser
participant Route as /[lang]/shop/[categoryId]/[productId]
participant Layout as layout.tsx
Note right of Layout #ddeeff: generateMetadata now typed with local Props
Browser->>Route: request product page
Route->>Layout: call generateMetadata({ params })
Layout-->>Route: returns Metadata
Route->>Layout: render page (uses Products data)
Layout->>Browser: HTML response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/i18n/en/common/enCommon.js (1)
205-207: Terminology drift: update “chevron” text to “patch”UI label already says “Patches”, but the ordering instructions still reference “chevrons”.
- PlacingOrderForChevron: - "If the size and colors (as shown in the photo) suit you, you can place an order. After submitting your request, our manager will contact you to confirm the details and send you the payment information\nOur website showcases samples of our designs. Each chevron is embroidered individually, so production takes 2-3 business days after payment\nIf you want to change the colors or size, please specify your preferences in the order comments. Our manager will discuss the changes with you via your preferred messenger\nIf you only wish to change the color, the price remains the same. If you need size adjustments, the price will be determined individually\nNot sure which one to choose? Feel free to write to our support chat — we're always happy to help!\nDone! If you have any doubts, we are here to assist you", + PlacingOrderForChevron: + "If the size and colors (as shown in the photo) suit you, you can place an order. After submitting your request, our manager will contact you to confirm the details and send you the payment information\nOur website showcases samples of our designs. Each patch is embroidered individually, so production takes 2–3 business days after payment\nIf you want to change the colors or size, please specify your preferences in the order comments. Our manager will discuss the changes with you via your preferred messenger\nIf you only wish to change the color, the price remains the same. If you need size adjustments, the price will be determined individually\nNot sure which one to choose? Feel free to write to our support chat — we're always happy to help!\nDone! If you have any doubts, we are here to assist you",Also applies to: 224-224
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
package-lock.jsonis excluded by!**/package-lock.jsonpublic/img/prints/foxes_100x100@3x.pngis excluded by!**/*.pngpublic/img/prints/foxes_385x355@3x.pngis excluded by!**/*.pngpublic/img/prints/leafs_on_blue_100x100@3x.pngis excluded by!**/*.pngpublic/img/prints/leafs_on_blue_385x355@3x.pngis excluded by!**/*.pngpublic/products/seat-bag-3l/seat-bag-3l_5_115x120@3x.pngis excluded by!**/*.pngpublic/products/seat-bag-3l/seat-bag-3l_5_460x580@3x.pngis excluded by!**/*.png
📒 Files selected for processing (12)
.github/workflows/deploy.yaml(1 hunks)src/components/deliveryPaymentPage/deliveryAndPayment/DeliveryAndPayment.tsx(1 hunks)src/data/data/fabrics/fabricsData.js(1 hunks)src/data/data/products.ts(15 hunks)src/i18n/en/common/enCommon.js(2 hunks)src/i18n/pl/common/plCommon.js(1 hunks)src/i18n/server/en/deliveryAndPayment/enDeliveryAndPayment.ts(1 hunks)src/i18n/server/meta/metaData.js(8 hunks)src/i18n/server/pl/deliveryAndPayment/plDeliveryAndPayment.ts(1 hunks)src/i18n/server/products/productsData.js(5 hunks)src/i18n/server/uk/deliveryAndPayment/ukDeliveryAndPayment.ts(1 hunks)src/i18n/uk/common/ukCommon.js(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: sonarqube
- GitHub Check: e2e-tests
🔇 Additional comments (23)
.github/workflows/deploy.yaml (1)
15-15: Consider scoping SENTRY_AUTH_TOKEN to specific jobs rather than top-level.Exposing secrets at the top-level environment makes them available to all jobs indiscriminately. If only certain jobs (e.g.,
deployment) need this token, scoping it to those jobs follows the principle of least privilege.Additionally, the provided workflow code doesn't show any usage of
SENTRY_AUTH_TOKENin the visible steps. Please verify which job(s) actually use this token.src/data/data/fabrics/fabricsData.js (1)
60-61: LGTM! New fabric prints added correctly.The addition of 'foxes' and 'leafs_on_blue' fabric prints follows the existing naming convention and array structure. These entries align with the corresponding translations added in
src/i18n/server/products/productsData.js.src/i18n/server/uk/deliveryAndPayment/ukDeliveryAndPayment.ts (1)
13-13: LGTM! Delivery text updated consistently.The Ukrainian delivery text has been updated to reflect that international delivery is now exclusively with Nova Poshta. This change is consistent with the corresponding updates in English and Polish localization files.
src/i18n/server/pl/deliveryAndPayment/plDeliveryAndPayment.ts (1)
14-14: LGTM! Polish delivery text updated.The Polish localization has been updated to reflect the removal of Ukrposhta as a delivery option, now stating that international delivery is primarily with Nova Poshta. This change is consistent with updates in other language files.
src/i18n/pl/common/plCommon.js (1)
192-192: LGTM! Delivery options updated in Polish localization.The DeliveryDetails text has been updated to remove Ukrposhta from the list of international delivery companies, now listing only "Nova Poshta i Meest". This change is consistent with the broader PR objective to remove Ukrposhta as a delivery option.
src/components/deliveryPaymentPage/deliveryAndPayment/DeliveryAndPayment.tsx (2)
47-51: LGTM! UI updated to reflect delivery changes.The Ukraine shipping section has been updated to show only Nova Poshta, with the logo width adjusted to 115 pixels. This change aligns with the removal of Ukrposhta as a delivery option throughout the application.
54-63: LGTM! International shipping section updated.The abroad shipping section now displays only the Nova Poshta International logo, consistent with the removal of Ukrposhta as an international delivery option. The component structure is clean and aligned with the updated delivery text.
src/i18n/server/products/productsData.js (9)
432-441: LGTM! Terminology updated from Chevron to Patch.The product name and description have been consistently updated across all three languages to use "Patch" terminology instead of "Chevron". The key name
ChevronLetsGoremains unchanged, which is good for maintaining backward compatibility with existing code references.
443-451: LGTM! ChevronStrava updated consistently.The Strava patch has been updated with the new terminology across all language packs, maintaining consistency with other Chevron-to-Patch migrations.
453-461: LGTM! ChevronVelocats terminology updated.The Velocats patch descriptions have been updated consistently across all three language packs.
463-471: LGTM! ChevronCoffee descriptions updated.The Coffee patch has been updated with the new Patch terminology consistently across all languages.
473-481: LGTM! ChevronDonut updated with Patch terminology.The Donut patch descriptions follow the same consistent pattern of terminology migration.
483-491: LGTM! ChevronGhost terminology updated.The Ghost patch has been updated consistently with the new terminology across all language packs.
493-501: LGTM! ChevronHeart descriptions updated.The Heart patch has been updated with the new Patch terminology consistently.
503-511: LGTM! ChevronSlice terminology updated.The Slice patch has been updated with the new terminology, completing the consistent migration from Chevron to Patch across all items.
892-896: LGTM! New fabric print translations added.The translations for 'foxes' and 'leafs_on_blue' fabric prints have been added correctly across all three language packs. These entries correspond to the new fabric prints added in
src/data/data/fabrics/fabricsData.js(lines 60-61).Also applies to: 917-921
src/i18n/server/en/deliveryAndPayment/enDeliveryAndPayment.ts (1)
14-14: LGTM! English delivery text updated.The English localization has been updated to reflect that international delivery is primarily with Nova Poshta, removing the Ukrposhta reference. This change is consistent with updates in Ukrainian and Polish localization files.
src/i18n/uk/common/ukCommon.js (2)
238-238: LGTM! Category renamed from Chevrons to Patches.The Ukrainian translation for the Chevrons category has been updated to "Патчі" (Patches), maintaining consistency with terminology changes throughout the codebase.
216-216: LGTM! Ordering instructions updated with Patch terminology.The PlacingOrderForChevron text has been comprehensively updated to use "патч" (patch) terminology throughout, providing clear instructions that align with the category name change.
src/data/data/products.ts (4)
183-184: Gallery count change: validate assets existseatBag3L gallery changed to 4. Ensure 4 images exist and downstream components don’t assume old count.
725-725: Flat price shape vs fabric‑based shapehandlebarMount uses a flat
{ UAH, EUR }while most others are per‑fabric. ConfirmProducttype supports both shapes and UI renders both correctly.
1188-1204: Original review comment is incorrect — product IS included in Products() arrayThe search confirms that
hamsterCorduraNavyBlueFoxesis already present in the Products() array at line 1198, which falls within the reviewed code snippet (lines 1188–1204). No action needed.Likely an incorrect or invalid review comment.
117-119: Price parity is mostly consistent; verify 3 outlier entriesAnalysis of 40+ price pairs shows median UAH/EUR rate of 37.01 with 94% of entries within ±10% (acceptable rounding variation). However, three outliers deviate beyond ±10%:
- Line 388: xpac 3700 UAH / 90 EUR = 41.11 (+11%)
- Line 677: xpac 550 UAH / 17 EUR = 32.35 (−12%)
- Line 725: handlebarMount 900 UAH / 28 EUR = 32.14 (−13%)
Verify these are intentional product-specific pricing or correct if data entry errors. No systemic refactor required; the majority follows a consistent implicit rate.
… into 6-prices-update
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/i18n/uk/common/ukCommon.js (1)
199-200: Consider clarifying the international delivery wording.The phrase "іншою перевізною компанією" (another carrier company) followed by listing "Нова Пошта" may be confusing since Nova Poshta is already mentioned for domestic delivery. The word "іншою" (another) implies a different company, but Nova Poshta appears in both contexts.
Consider revising to remove ambiguity:
DeliveryDetails: - 'Доставка по Україні відбувається Новою Поштою\nДоставка по світу - іншою перевізною компанією (Нова Пошта, Meest)', + 'Доставка по Україні відбувається Новою Поштою\nМіжнародна доставка - Новою Поштою або Meest',Or alternatively:
DeliveryDetails: - 'Доставка по Україні відбувається Новою Поштою\nДоставка по світу - іншою перевізною компанією (Нова Пошта, Meest)', + 'Доставка по Україні відбувається Новою Поштою\nДоставка по світу - перевізною компанією (Нова Пошта, Meest)',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/i18n/server/meta/metaData.js(2 hunks)src/i18n/uk/common/ukCommon.js(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/i18n/server/meta/metaData.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: sonarqube
- GitHub Check: e2e-tests
…erties to Props type
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/[lang]/shop/[categoryId]/[productId]/layout.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: sonarqube
- GitHub Check: e2e-tests
…a from ProductPageLayoutProps for layout component
|
2 participants
Summary by CodeRabbit
Bug Fixes
Updates