change data type to ull, add regression test

bob80905 · Dec 2, 2023 · 6e251b0 · 6e251b0
1 parent 8a37a92
commit 6e251b0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/tools/clang/lib/Sema/SemaHLSL.cpp b/tools/clang/lib/Sema/SemaHLSL.cpp
@@ -13134,7 +13134,7 @@ void Sema::DiagnoseGloballyCoherentMismatch(const Expr *SrcExpr,
 
 void ValidateDispatchGridValues(DiagnosticsEngine &Diags,
                                 const AttributeList &A, Attr *declAttr) {
-  unsigned x = 1, y = 1, z = 1;
+  unsigned long long int x = 1, y = 1, z = 1;
   if (HLSLNodeDispatchGridAttr *pA =
           dyn_cast<HLSLNodeDispatchGridAttr>(declAttr)) {
     x = pA->getX();

diff --git a/tools/clang/test/SemaHLSL/attributes/overflow_node_dispatch_grid.hlsl b/tools/clang/test/SemaHLSL/attributes/overflow_node_dispatch_grid.hlsl
@@ -0,0 +1,7 @@
+// RUN: %dxc -T lib_6_8 -verify %s
+
+[Shader("node")]
+[NodeLaunch("broadcasting")]
+[NodeDispatchGrid(65535, 65535, 65535)] // expected-error {{'NodeDispatchGrid' X * Y * Z product may not exceed 16,777,215 (2^24-1)}}
+[NumThreads(1, 1, 1)]
+void myNode() { }