Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gateway stability to complete e2e #1231

Closed

Conversation

sk-enya
Copy link
Contributor

@sk-enya sk-enya commented Sep 27, 2023

📋 Add associated issues, tickets, docs URL here.

Overview

Looks like the gateway is not working correctly while switching between networks / l1 to l2 / listening to the meta mask network change event.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • clean up fetch balances from home.js
  • update walletSelector modal closes before triggering event
  • closing wallet selector modal after initialized success
  • clean up state reset in wallet switch
  • fix: reverted state on accounts change from MM
  • chore: added compose enhancer for redux dev tools
  • fix: commented out tenderly URL to understand the cause of recursive calls to tenderly.

Testing

Describe how to test your new feature/bug fix and if possible, a step-by-step guide on how to demo this.

 - clean up fetch balances from home.js
 - update walletSelector modal closes before triggering event
 - closing wallet selector modal after initlized success
 - clean up state reset in wallet switch
 - fix: reverted state on accounts change from MM
 - chore: added compose enhancer for redux devtools
 - fix: commented out tenderly url to understand the cause of recursive calls to tenderly.
@sk-enya sk-enya marked this pull request as draft September 27, 2023 13:39
@sk-enya sk-enya self-assigned this Sep 27, 2023
@sk-enya
Copy link
Contributor Author

sk-enya commented Sep 30, 2023

Closing as repo has changed now!

@sk-enya sk-enya closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant