Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchorage Enable For BNB-Testnet #586

Merged
merged 27 commits into from
Jul 29, 2024
Merged

Anchorage Enable For BNB-Testnet #586

merged 27 commits into from
Jul 29, 2024

Conversation

sk-enya
Copy link
Collaborator

@sk-enya sk-enya commented Jul 16, 2024 •
edited

📋
closes: #584

Overview

Enable Anchorage Bridging Deposit & 2 Step Withdrawal for BNB Testnet.

Tasks

  • No debug console statement added
  • Should use only typescript.
  • Does have unit test for each touched file with 90% coverage
  • Does have an integration test if any UI changes.

Changes

  • Enable anchorage bridging flag for BNB Testnet.
  • Added bridge service
  • function to deposit native tokens with optimism portal contract for Eth
  • optimism portal contract for BNB & Boba deposit on BNB Testnet
  • Clean up unused function updated specs.
  • Show recipient details on bridge confirmation modal.
  • Disable wheel event on input button which resets value to 0 or negative.

Testing

Snapshots for test coverage for changed files.

UI Snaps

Add screenshots or video if any visuals changes are there so would be helpful for review.

This was referenced Jul 16, 2024
Closed
Closed
Closed
@sk-enya
updated outdated packages.
7026f0f
@sk-enya
change:
b45fa2f 
- added bridge service
- function to deposit native tokens with optimism portal contract for eth
- optimism portal contract for BNB & Boba deposit as well.
- clean up unused function updated specs.
- Show recipient details on bridge confirmation modal.
- disable wheel event on input button which resets value to 0 or negative.
@sk-enya
change- alert to be load from bottom right
9a7c84a
@sk-enya
change:
ea1a361 
- simplyfied trigger submit logic
- updated depositAnchroageERC20 with correct handling & bridge.service change.
- disable useBridge spec block.
@sk-enya
change: removed unused function from network service.
2f60f17
@sk-enya
clean up unused code for anchorage deposit.
5398744
@sk-enya
reverted optimismPortal contract initiation as it's getting use inter…
a5a671f 
…nally.
wsdt
wsdt approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@wsdt wsdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sk-enya sk-enya merged commit 857e107 into main Jul 29, 2024
3 of 4 checks passed
@sk-enya sk-enya deleted the feature/bnb-enable-anchorage-testnet branch August 29, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsdt wsdt wsdt approved these changes

@boyuan-chen boyuan-chen boyuan-chen approved these changes

@alvaro-ricotta alvaro-ricotta Awaiting requested review from alvaro-ricotta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Anchorage Bridging BNB Testnet with Cleanup
3 participants
@sk-enya @wsdt @boyuan-chen