fix: improve KMS error handling #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsdt
changed the title
|
Are we good with this PR? #43 |
|
wsdt
changed the title
… wsdt/kms-update # Conflicts: # package.json # pnpm-lock.yaml
|
Hello @wsdt, I was also facing the same issues so have to downgrade the package to older version to keep the test running. will take look on what wrong here, tried spending some time earlier but let me dig more into it. |
thanks Sahil! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@boyuan-chen @sk-enya looks like the changes in the past few weeks/months (just an assumption) on the graph-utils repo have broken the tests on the lightbridge. I have downgraded the package for now to have the pipeline green again.
Added a ticket on my end to check why the tests are failing (seems like some require/import commonjs incompatibility). But if you guys know already what it might be, would be great if you could create a PR. Thx!
EDIT: Looks like the old package can't be used anymore. Tests go way further but fail at a different point.
Just merged your PR into mine to make sure my own changes don't break anything. Would be great if we could check why the graph-utils package breaks the tests.