Ensures txpool recovers sender for txes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
force-pushed
the
jyellick/verify-sender-recovery
branch
from
e160ad1
to
d5ad45a
Compare
There seems to be a bug where the txpool may not appropriately set the sender address. This leads to incorrectly admitting transactions into mining blocks, as the wrong address is referenced. This commit adds a check that if the sender address is not set, it attempts to directly recover the sender from the transaction data and set that instead.
jyellick
force-pushed
the
jyellick/verify-sender-recovery
branch
from
d5ad45a
to
237a74a
Compare
mmontour1306
approved these changes
May 17, 2024
boyuan-chen
approved these changes
May 17, 2024
Add additional logging around l1cost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug where the txpool may not appropriately set the sender address. This leads to incorrectly admitting transactions into mining blocks, as the wrong address is referenced.
This commit adds a check that if the sender address is not set, it attempts to directly recover the sender from the transaction data and set that instead.