-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support for v0.7 AA contracts. #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates protocol version to 0.3 in offchain-RPC calls, updates Python examples. Other example / SDK repositories will also need to be updated. Applies some audit recommendations to HCHelper.
Changes to be committed: modified: crates/builder/src/bundle_proposer.rs modified: crates/rpc/src/eth/api.rs modified: crates/rpc/src/eth/router.rs modified: crates/types/src/hybrid_compute.rs modified: crates/types/src/user_operation/mod.rs modified: crates/types/src/user_operation/v0_6.rs modified: crates/types/src/user_operation/v0_7.rs
as suggested by audit. The index of the ResponseCache storage slot is now detected rather than being hard-coded. Changes to be committed: modified: bin/rundler/src/cli/mod.rs modified: crates/rpc/src/eth/api.rs modified: crates/rpc/src/eth/router.rs modified: crates/types/contracts/src/hc0_7/HCHelper.sol modified: crates/types/src/hybrid_compute.rs
Changes to be committed: modified: bin/rundler/src/cli/mod.rs modified: crates/rpc/src/eth/api.rs modified: crates/types/src/hybrid_compute.rs
Changes to be committed: modified: aa_utils/__init__.py modified: offchain/offchain_utils.py
Changes to be committed: modified: deploy-local.py
Changes to be committed: modified: ../crates/types/contracts/src/hc0_7/TestHybrid.sol
Changes to be committed: modified: hc_scripts/LocalDeploy_v7.s.sol
wsdt
reviewed
Nov 12, 2024
} | ||
} | ||
// EntryPointAddr is hard-coded for the v0.7 implementation | ||
ept = EntryPoint(payable(0x0000000071727De22E5E9d8BAf0edAc6f37da032)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I assume this is a create2 deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a create2 address.
wsdt
approved these changes
Nov 12, 2024
Note: this will require us to update the SDKs too. |
katieclay
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates protocol version to 0.3 in offchain-RPC calls, updates Python examples. Other example / SDK repositories will also need to be updated. Applies some audit recommendations to HCHelper.
[Closes/Fixes] #
Proposed Changes