Separate docker initialisation from images #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
approved these changes
Jul 30, 2024
ops/docker/Dockerfile.init
Outdated
| @@ -0,0 +1,31 @@ | |||
| FROM node:20 | |||
There was a problem hiding this comment.
Why node:20? Seems like we should possibly be simply pulling a Cargo build env? If we need Node at runtime for the ts scripts, perhaps we would be better off copying the built binary into a Node env? Presumably we do not need to build any rust at runtime?
There was a problem hiding this comment.
good point! will change that
| @@ -277,10 +299,10 @@ export class AdminZkRandService extends BaseService<AdminZkRandOptions> { | |||
| await waitForWriteJsonToFile(obj, instancesPath) | |||
| console.log("retrieved all instances from contract") | |||
| console.log("sleeping..") | |||
| await sleep(2000) | |||
| await sleep(5000) | |||
There was a problem hiding this comment.
Can we not wait for this asynchronously?
There was a problem hiding this comment.
writing to disk takes some time to finish. The command after will fail if no wait or not enough delay
| @@ -169,10 +192,10 @@ export class NodeZkRandService extends BaseService<NodeZkRandOptions> { | |||
| const obj = JSON.stringify(ppListHex) | |||
| await waitForWriteJsonToFile(obj, instancesPath) | |||
| console.log("sleeping..") | |||
| await sleep(1000) | |||
| await sleep(5000) | |||
There was a problem hiding this comment.
Same comment here with respect to async wait?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.