Prepare to Firebase 3 Upgrade #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis CI is falling because it is not finding npm and karma-cli in order to perform the tests (seems like they are not installed on the VMs). We just need configure before_install option at .travis.yml, ensuring that packages are present before starting the unit tests.
Update all files that mention BackboneFire reference number to v0.5.1.
Minor .gitignore upgrade: - Remove duplicated folders - Upgrade list of automatically created files that should be ignored - Use GitHub Node.js .gitignore template (see https://goo.gl/hx0XE) - Also ignore Emacs and VSCode automatic files
Update required in order to Travis CI run the unit tests
Updated all package dependencies to its latest version, except Firebase and Backbone. This is an intermediary step before actually upgrading to latest backend version. Removed gulp-server and use gulp-contrib-connect instead (updating Gruntfile.js task also is required to perform the unit tests). We also installed chai and sinon because they are required by karma-chai and karma-sinon respectivelly.
Fix Backbone.Firebase.Collection#fetch test to properly check if a collection was successfully synced with Firebase backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications are preparatory steps before actually updating the project to the latest Firebase and Backbone versions:
npmandkarma-cliin order to perform the tests (seems like they are not installed on the VMs).before_installoption at.travis.yml, ensuring that packages are present before starting the unit tests.Fix: googlearchive#157