Fixed Parameter (ServiceInfo) #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!Parameter for creating ServiceInfo where in wrong order (probably due to API changes in zeroconf (guess))
Merging Changes from origin
+ Enabling Port Ranges to be used for devices (Makes it possible to connect multiply devices of the same type)
More Devices
* Configuration over a dedicated configuration File
+ making it possible to specify a protocol for the gateway device class + a bit more detailed log when connecting devices
!Move Redirection Initialisation into the try block, since it also sends data and can be affected by IOExceptions (will crash whole Device Loop if not moved)
How a unqiue name is generated can depends on the device, many devices have the same vendor and model (most integrated usb / serial converters for instance)
just the serial und company name (vendor_enc) alone should be globaly unique.
This reverts commit 9f5fca1.
default Name for port ranges
sarad device unique name
Protokoll should probably start with _ as well.
Fixed Sarad Gateway
Not starting from outside the directory
Debugging Changes (Temp)
+: Improve README ~: follow PyLint hints
introduce typing
sarad-1688 goes into serial_short. This fits better to the ZeroConf standard.
~: make code more concise
…N_Modul/spc-sarad_network/src-instrumentserver2-rfc2217 into master
~: add debug log entries
…l/spc-sarad_network/src-instrumentserver2-rfc2217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!Parameter for creating ServiceInfo where in wrong order (probably due to API changes in zeroconf (guess))
(The change was in this commit: python-zeroconf/python-zeroconf@0a9aa8d
between version 0.27.1 and 0.28)