Skip to content

Conversation

@njriasan
Copy link
Contributor

Adds a github workflow for pip release.

@njriasan njriasan marked this pull request as draft December 28, 2024 00:57
@njriasan njriasan marked this pull request as ready for review December 30, 2024 01:40
@njriasan njriasan changed the title [WIP] [BSE-4430] Add a workflow step for pip release [BSE-4430] Add a workflow step for pip release Dec 30, 2024
id-token: write
name: Upload PyDough Wheels

if: github.event_name == 'release' && github.event.action == 'published'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only step that isn't properly tested. I had problems because I tried to setup the OIDC step on pypi and the package name was already taken. I've asked about next steps on slack. However, the testing steps pass, so I don't think this should be a blocker since we can test once we determine how to proceed.

@njriasan njriasan requested a review from IsaacWarren December 30, 2024 01:42
Copy link
Contributor

@IsaacWarren IsaacWarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick

Base automatically changed from nick/pip_build_system to main January 2, 2025 19:30
@njriasan njriasan merged commit 03810b4 into main Jan 2, 2025
4 checks passed
@njriasan njriasan deleted the nick/build_pydough_pip branch January 2, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants