-
Notifications
You must be signed in to change notification settings - Fork 4
Adding custom & s3 tests infrastructure #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ed53c99
WIP: downloading from s3
john-sanchez31 a05fab6
testing infrastructure for s3 custom datasets [run ci]
john-sanchez31 fddceff
flag run custom for custom dataset tests created
john-sanchez31 26d039c
adding all connectors for custom test
john-sanchez31 cd894dd
synthea s3 testing, adding bug test [run custom]
john-sanchez31 7b1f1f0
excluding custom test for [run ci] [run custom]
john-sanchez31 277aea7
now dialect flag does not run custom tests
john-sanchez31 4fc6a2f
testing [run all]
john-sanchez31 dce5428
adding mark and secrets for custom tests [run all]
john-sanchez31 1af103d
set env for custom dataset [run all]
john-sanchez31 2ee3a34
custom ci separated [run all]
john-sanchez31 5680d1f
secret name fixed [run all]
john-sanchez31 78fb6e5
comments addressed [run all]
john-sanchez31 447fcb4
keeping the db files
john-sanchez31 654b105
custom and s3 datasets separated
john-sanchez31 cf2aac2
s3 flag created [run s3]
john-sanchez31 f116a22
conlficts solved [run s3]
john-sanchez31 10b2e23
testing [run all]
john-sanchez31 68e2139
fixture added [run all]
john-sanchez31 47fef7f
testing [run ci]
john-sanchez31 25e1474
no initialized db fixed [run all]
john-sanchez31 fa6f4d1
init script added [run all]
john-sanchez31 339d1a5
minor fixes [run all]
john-sanchez31 8996c48
comment fixed [run all]
john-sanchez31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| name: Run Custom Tests All dialects | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| python-versions: | ||
| description: "JSON string of Python versions" | ||
| type: string | ||
| required: true | ||
| secrets: | ||
| READ_LLM_FIXTURES_ROLE: | ||
| required: true | ||
| SF_USERNAME: | ||
| required: true | ||
| SF_PASSWORD: | ||
| required: true | ||
| SF_ACCOUNT: | ||
| required: true | ||
| MYSQL_USERNAME: | ||
| required: true | ||
| MYSQL_PASSWORD: | ||
| required: true | ||
| POSTGRES_USER: | ||
| required: true | ||
| POSTGRES_PASSWORD: | ||
| required: true | ||
|
|
||
| jobs: | ||
| custom-tests: | ||
| name: Custom Tests (Python ${{ matrix.python-version }}) | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| strategy: | ||
| matrix: | ||
| python-version: ${{ fromJSON(inputs.python-versions) }} | ||
|
|
||
| # Define services here to run Docker containers alongside your job | ||
| services: | ||
| mysql: | ||
| image: bodoai1/pydough-mysql-tpch:latest | ||
| env: | ||
| # Set environment variables for MySQL container | ||
| MYSQL_ROOT_PASSWORD: ${{ secrets.MYSQL_PASSWORD }} | ||
| MYSQL_DATABASE: tpch | ||
| ports: | ||
| - 3306:3306 | ||
|
|
||
| postgres: | ||
| image: bodoai1/pydough-postgres-tpch:latest | ||
| env: | ||
| # Set environment variables for Postgres container | ||
| POSTGRES_USER: ${{ secrets.POSTGRES_USER }} | ||
| POSTGRES_PASSWORD: ${{ secrets.POSTGRES_PASSWORD }} | ||
| POSTGRES_DB: "pydough_test" | ||
| ports: | ||
| - 5432:5432 | ||
| env: | ||
| # MYSQL env | ||
| MYSQL_USERNAME: ${{ secrets.MYSQL_USERNAME }} | ||
| MYSQL_PASSWORD: ${{ secrets.MYSQL_PASSWORD }} | ||
| MYSQL_DATABASE: tpch | ||
| MYSQL_HOST: 127.0.0.1 | ||
| # POSTGRES env | ||
| POSTGRES_USER: ${{ secrets.POSTGRES_USER }} | ||
| POSTGRES_PASSWORD: ${{ secrets.POSTGRES_PASSWORD }} | ||
| POSTGRES_DB: pydough_test | ||
| POSTGRES_HOST: 127.0.0.1 | ||
| # SNOWFLAKE env | ||
| SF_USERNAME: ${{ secrets.SF_USERNAME }} | ||
| SF_PASSWORD: ${{ secrets.SF_PASSWORD }} | ||
| SF_ACCOUNT: ${{ secrets.SF_ACCOUNT }} | ||
|
|
||
| steps: | ||
| - name: Configure AWS Credentials (OIDC) | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ secrets.READ_LLM_FIXTURES_ROLE }} | ||
| aws-region: us-east-2 | ||
|
|
||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python ${{ matrix.python-version }} | ||
| id: setup-python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v3 | ||
| with: | ||
| version: "0.4.23" | ||
|
|
||
| - name: Create virtual environment | ||
| run: uv venv | ||
|
|
||
| - name: Install dependencies | ||
| run: uv pip install -e ".[boto3, snowflake, mysql, postgres]" | ||
|
|
||
| - name: Confirm all connectors are installed | ||
| run: uv run python -c "import boto3; import mysql.connector; import snowflake.connector; import psycopg2; print('All connectors installed')" | ||
|
|
||
| - name: Run Custom Tests for all dialects | ||
| run: uv run pytest -m custom tests/ -rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a context question, should these test be more like
s3_datasetsinstead ofcustom. Custom makes me think more to something likereserved words, datasets from our repo created by us and customized for edge cases instead of public datasets stored in aws.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with that. I believe he just used what the test file name was.