Call Expression Alias Patch #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-sanchez31
requested review from
a team,
hadia206,
juankx-bodo and
knassre-bodo
and removed request for
a team
hadia206
approved these changes
Nov 17, 2025
Contributor
hadia206
left a comment
hadia206
left a comment
There was a problem hiding this comment.
Good job John.
Please address comment before merging.
pydough/conversion/column_bubbler.py
Outdated
Comment on lines
84
to
87
| input_expr.name.startswith('"') | ||
| and input_expr.name.endswith('"') | ||
| or input_expr.name.startswith("`") | ||
| and input_expr.name.endswith("`") |
Contributor
There was a problem hiding this comment.
Why use input_expr.name instead of input_name here?
Contributor
Author
There was a problem hiding this comment.
No particular reason but I'm gonna use it
pydough/conversion/column_bubbler.py
Outdated
Comment on lines
79
to
80
| input_name: str = input_expr.name | ||
| quoted: bool = False |
Contributor
There was a problem hiding this comment.
I think the better fix here is to not do any of this special handling, but instead just remove all characters from input_name except letters/numbers/underscores. We don't have to worry about conflicts because the point of this function is that it returns potential alternative names, and it only uses if them if those names are not already in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #458