Ensure semantic information is all correctly stored in the metadata #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: john-sanchez31 <[email protected]>
knassre-bodo
requested review from
a team,
hadia206,
john-sanchez31 and
juankx-bodo
and removed request for
a team
john-sanchez31
approved these changes
Dec 22, 2025
Contributor
john-sanchez31
left a comment
john-sanchez31
left a comment
There was a problem hiding this comment.
Looks good! Thanks Kian
hadia206
approved these changes
Dec 22, 2025
Contributor
hadia206
left a comment
hadia206
left a comment
There was a problem hiding this comment.
Looks good.
Thanks Kian!
juankx-bodo
approved these changes
Dec 22, 2025
pydough/metadata/parse.py
Outdated
| None, | ||
| None, | ||
| {}, | ||
| extra_info, |
Contributor
There was a problem hiding this comment.
Should this variable be named extra_semantic_info instead of extra_info? To keep consistence with the other names that use the same name as the JSON file and class property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extra tests to ensure the extra semantic information fields (sample values, description, extra semantic info, synonyms, verified pydough analysis, additional definitions) are all present in graph/collection/property metadata. Modifies the parsing to account for cases where the information is not already being passed along, and modifies the TPC-H graph to add some extra semantic information of this variety.