Merge pull request #8 from boettiger-lab/nice-little-things

Nice little things

hyperpars/rppo-caribou.yml

@@ -8,6 +8,6 @@ tensorboard: "/home/rstudio/logs"
 total_timesteps: 500000
 config: {}
 use_sde: True
-id: "1"
+# id: "1"
 repo: "boettiger-lab/rl4eco"
 save_path: "/home/rstudio/rl4caribou/saved_agents"

hyperpars/td3-caribou.yml

@@ -5,6 +5,6 @@ env_id: "CaribouScipy"
 config: {}
 tensorboard: "/home/rstudio/logs"
 total_timesteps: 500000
-id: "1"
+# id: "1"
 repo: "boettiger-lab/rl4eco"
 save_path: "/home/rstudio/rl4caribou/saved_agents"

scripts/train.py

@@ -2,7 +2,8 @@
 import argparse
 parser = argparse.ArgumentParser()
 parser.add_argument("-f", "--file", help="Path config file", type=str)
-parser.add_argument("-pb", "--progress_bar", help="Use  progress bar for training", type=bool)
+parser.add_argument("-pb", "--progress_bar", help="Use  progress bar for training", type=bool, default=True)
+parser.add_argument("-id", "--identifier", help="ID string for saving the agent", type=bool, default="0")
 args = parser.parse_args()
 
 import rl4caribou
@@ -21,6 +22,7 @@
 #
 from rl4caribou.utils import sb3_train    
 model_save_id, train_options = sb3_train(abs_filepath, progress_bar=args.progress_bar)
+model_save_id = model_save_id + "_id_" + args.identifier
 
 # hugging face
 #

src/rl4caribou/utils/sb3.py

@@ -63,9 +63,9 @@ def sb3_train(config_file, **kwargs):
         options['algo_config']['policy_kwargs'] = eval(options['algo_config']['policy_kwargs'])
 
     ALGO = algorithm(options["algo"])
-    if "id" in options:
-        options["id"] = "-" + options["id"]
-    model_id = options["algo"] + "-" + options["env_id"]  + options.get("id", "")
+    # if "id" in options:
+    #     options["id"] = "-" + options["id"]
+    model_id = options["algo"] + "-" + options["env_id"] # + options.get("id", "")
     save_id = os.path.join(options["save_path"], model_id)
 
     model = ALGO(