Training playing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboettig
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
@felimomo sorry i was slow getting to this, edits to the yaml look good! The other changes you mentioned up top:
- added ODE model env caribou_ode.CaribouScipy
- changes to training.py, sb3_train.py
- rebalanced utility fn
- updated yamls
- added simultaneous train script train_algos.sh
- added policy evaluation notebook
I think are already merged? haven't looked over those yet but probably fine, lemme know if there are particular parts of any of that I can look at!
I'll try and be faster at reading these, overall small PRs that change few files are great since easy to review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cboettig , I requested the review though we don't have main branch protection - I tried looking into protecting the branch but didn't see the option of require reviews pop up, so we'll have to look at that in more detail. Anyhow, I think it might be good to have a second pair of eyes on the code at this point!
Changes:
caribou_ode.CaribouScipytraining.py,sb3_train.pytrain_algos.sh