Conversation
boidolr
commented
Mar 8, 2026
Owner
- fix: more informative overall status check
- fix: handle ty errors with special characters
There was a problem hiding this comment.
Pull request overview
This PR updates the pytest-ty plugin’s diagnostic handling to better correlate ty failures with individual test files and to surface a more informative overall status when multiple files fail.
Changes:
- Switch
ty checkinvocation to a structured output format and parse diagnostics via JSON instead of splitting colon-delimited strings. - Improve the status item error output to include all diagnostic messages (not just file keys).
- Extend tests to cover multiple failing files and a failure case involving diagnostics that previously risked parsing issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_pytest_ty.py |
Adds fixtures and new assertions to ensure multiple-file failures and parsing-sensitive diagnostics are correctly attributed and reported. |
src/pytest_ty/plugin.py |
Changes ty output format, parses JSON diagnostics into per-file errors, and improves status aggregation output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.