Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for heix (iOS 18) #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robbassi
Copy link

@robbassi robbassi commented Jul 19, 2024

We ran into some issues processing HEIC files from iOS 18 devices. It looks like Apple changed some of the metadata for HEIC files on the latest release.

This what we typically see for a HEIC file:

$ xxd -d -c 16 -l 16 -b test.heic 
[bytes truncated] 01100011 00000000 00000000 00000000 00000000  ....ftypheic....
$ xxd -d -c 16 -l 16 -b sample.heic
[bytes truncated] 00110001 00000000 00000000 00000000 00000000  ....ftypmif1....

But the HEIC images we get from iOS 18 contain the following:

$ xxd -d -c 16 -l 16 -b sample2.heic
[bytes truncated] 01111000 00000000 00000000 00000000 00000000  ....ftypheix....

Testing it with file, we see the mime-type is:

$ file --mime-type sample2.heic 
sample2.heic: image/heic

This PR updates the check for heic to include heix, and adds a new test case + test data.

@stephenjudkins
Copy link

Nice work @robbassi! Rob is going to be on vacation for the next month so I can handle any feedback here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants