Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bokeh's ianthomas23/13732_maybe_initialize branch #31

Merged
merged 1 commit into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

- name: Clone bokeh branch
run: |
git clone -b ianthomas23/bokehjs_examples_temp --single-branch --depth 1 https://github.com/bokeh/bokeh.git
git clone -b ianthomas23/13732_maybe_initialize --single-branch --depth 1 https://github.com/bokeh/bokeh.git

- name: Build bokehjs
working-directory: bokeh/bokehjs
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ installed.

```bash
cd <directory of choice>
git clone -b ianthomas23/bokehjs_examples_temp --single-branch --depth 1 https://github.com/bokeh/bokeh.git
git clone -b ianthomas23/13732_maybe_initialize --single-branch --depth 1 https://github.com/bokeh/bokeh.git
cd bokeh/bokehjs
node make build
npm pack
```

This will produce the file `bokeh-bokehjs-3.7.0-dev.5.tgz` which should be copied to the root
This will produce the file `bokeh-bokehjs-3.8.0-dev.1.tgz` which should be copied to the root
directory of the bokehjs-examples repository.
2 changes: 1 addition & 1 deletion ci/typescript/create_vanilla_rspack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ rm temp.json
# In a web browser navigate to http://localhost:4500/

# 9. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level README.md.
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz

# 10. Replace contents of src/index.ts with code to create BokehJS plot
mkdir -p src
Expand Down
2 changes: 1 addition & 1 deletion ci/typescript/create_vanilla_vite.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ EOF
# In a web browser navigate to http://localhost:5173/

# 6. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level README.md.
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz

# 7. Replace src/main.ts with a simple hello example
cat > src/main.ts << EOF
Expand Down
2 changes: 1 addition & 1 deletion ci/typescript/create_vanilla_webpack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ rm temp.json
# In a web browser navigate to http://localhost:4500/

# 9. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level README.md.
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz

# 10. Replace contents of src/index.ts with code to create BokehJS plot
mkdir -p src
Expand Down
2 changes: 1 addition & 1 deletion recipes/src/recipes/typescript/vanilla_rspack_recipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default config;`)
this.add(new CommandStep(
'Add BokehJS dependency to this project. This assumes the package has been built and ' +
'copied to the root directory of this repository as outlined in the top-level `README.md`.',
['npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz']
['npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz']
));

this.add(new CreateFileStep(
Expand Down
2 changes: 1 addition & 1 deletion recipes/src/recipes/typescript/vanilla_vite_recipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class VanillaViteRecipe extends Recipe {
this.add(new CommandStep(
'Add BokehJS dependency to this project. This assumes the package has been built and ' +
'copied to the root directory of this repository as outlined in the top-level `README.md`.',
['npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz']
['npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz']
));

this.add(new ReplaceFileStep(
Expand Down
2 changes: 1 addition & 1 deletion recipes/src/recipes/typescript/vanilla_webpack_recipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default config;`)
this.add(new CommandStep(
'Add BokehJS dependency to this project. This assumes the package has been built and ' +
'copied to the root directory of this repository as outlined in the top-level `README.md`.',
['npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz']
['npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz']
));

this.add(new CreateFileStep(
Expand Down
2 changes: 1 addition & 1 deletion typescript/vanilla_rspack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ This is almost identical to the vanilla webpack example, as `rspack` is designed
9. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level `README.md`.

```bash
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz
```

10. Replace contents of `src/index.ts` with code to create BokehJS plot containing
Expand Down
2 changes: 1 addition & 1 deletion typescript/vanilla_vite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Create an initial basic project using `create-vite`.
6. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level `README.md`.

```bash
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz
```

7. Replace `src/main.ts` with a simple hello example containing
Expand Down
2 changes: 1 addition & 1 deletion typescript/vanilla_webpack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
9. Add BokehJS dependency to this project. This assumes the package has been built and copied to the root directory of this repository as outlined in the top-level `README.md`.

```bash
npm install ../../../../bokeh-bokehjs-3.7.0-dev.5.tgz
npm install ../../../../bokeh-bokehjs-3.8.0-dev.1.tgz
```

10. Replace contents of `src/index.ts` with code to create BokehJS plot containing
Expand Down