Skip to content

Attempt to fix communication issues #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Attempt to fix communication issues #93

merged 3 commits into from
Apr 27, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Apr 15, 2023

Early WIP. There's a lot I don't understand and a lot that doesn't work. Moreover ipywidgets 8.0.5 breaks things even more.

@mattpap mattpap added the task label Apr 15, 2023
@philippjfr
Copy link
Contributor

@mattpap Can you rebase and merge this and then tag a dev release? In combination with changes I made in Panel this works fine for me, even with 8.0.6. Happy to help fix this for pure-bokeh users once the Panel 1.0 rush is over.

@mattpap mattpap force-pushed the mattpap/comms_fixes branch from aff16dc to a8ab35c Compare April 27, 2023 13:01
@mattpap
Copy link
Contributor Author

mattpap commented Apr 27, 2023

Can you rebase and merge this and then tag a dev release? In combination with changes I made in Panel this works fine for me, even with 8.0.6. Happy to help fix this for pure-bokeh users once the Panel 1.0 rush is over.

This still doesn't work for me in Bokeh (with ipywidgets 8.0.6 at all and with 8.0.4 the same as with original changes in this PR, i.e. only one way). I rebased and will publish a release soon.

@mattpap
Copy link
Contributor Author

mattpap commented Apr 27, 2023

@philippjfr, what specifically were you testing in panel?

@mattpap mattpap merged commit 7ea0842 into main Apr 27, 2023
@mattpap mattpap deleted the mattpap/comms_fixes branch April 27, 2023 13:10
@philippjfr
Copy link
Contributor

import panel as pn

import ipywidgets as ipw

pn.extension('ipywidgets')

slider = ipw.IntSlider(min=0, end=14)

md = pn.pane.Markdown()

button = pn.widgets.Button(name='Reset')

def reset(event):
    slider.value = 0

button.on_click(reset)

def update_zoom(event):
    if isinstance(event['new'], int):
        md.object = str(event['new'])
    elif 'value' in event['new']:
        md.object = str(event['new']['value'])

slider.observe(update_zoom)

pn.Column(ipw.__version__, button, slider, md).servable()

ipywidgets_8 0 6

Depends on holoviz/panel#4716

@ndmlny-qs
Copy link
Collaborator

I can confirm that this is working for me as well. I also removed the src/ipywidgets_bokeh/webpack.ts module and it works as expected.

no-webpack-module.webm

env

name: panel-upgrade-releases
channels:
  - conda-forge
  - pyviz/label/dev
dependencies:
  - python<3.11
  - nodejs # for ipywidgets_bokeh build
  - pip
  - ipywidgets
  - pyviz/label/dev::panel==1.0.0rc1
  - ipython_genutils
  - ipyvolume

@hoxbro hoxbro mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants