Remove unused webpack.ts #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`src/webpack.ts` is not used, and is removed in this commit. The following files - `index.ts` - `loader.ts` - `manager.ts` have been modified to remove commented out code, and fixes a few `!=` and `==` where they should be `!==` and `===`.
|
This code actually seems to be doing something. Before this PR: and after: The warnings in the before image are the doing of my PR #95. |
mattpap
reviewed
May 2, 2023
|
thanks for showing this does something. do you know why it is using these fonts? I don't fully understand why a wraper would need fonts, but I'll close it out |
|
I think fonts are used for icons in ipyvolume's toolbar, which is currently broken regardless (it's actually sort of present in Firefox). I would be happy to get rid of this code, but I suppose there will be another mechanism necessary to load resources like fonts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/webpack.tsis not used, and is removed in this commit.The following files
index.tsloader.tsmanager.tshave been modified to remove commented out code, and fixes a few
!=and==where they should be!==and===.