Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize _events property #210

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Initialize _events property #210

merged 1 commit into from
Mar 10, 2025

Conversation

tfehlmann
Copy link
Contributor

The _events property is currently uninitialized which results in a runtime error in the _consume_patch function.

Copy link
Contributor

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down. Would be nice if we had some integration tests here.

@philippjfr
Copy link
Contributor

(To be clear I'm not asking you to add those)

@bryevdv
Copy link
Member

bryevdv commented Mar 7, 2025

@philippjfr do you want to merge this as-is with a follow-up issue for more tests, or do you want to wait for someone to add tests to this branch?

Copy link
Contributor

@mattpap mattpap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically makes sense. Regression tests would be good to have.

@mattpap mattpap added this to the 4.0.6 milestone Mar 10, 2025
@mattpap mattpap merged commit 81774e3 into bokeh:main Mar 10, 2025
2 checks passed
@mattpap
Copy link
Contributor

mattpap commented Mar 10, 2025

@tfehlmann, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants