Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate transformers, etc... to qiime2/q2-types #105

Open
mikerobeson opened this issue Apr 9, 2021 · 4 comments
Open

Migrate transformers, etc... to qiime2/q2-types #105

mikerobeson opened this issue Apr 9, 2021 · 4 comments

Comments

@mikerobeson
Copy link
Collaborator

mikerobeson commented Apr 9, 2021

Given the recent updates to q2-types (qiime2/q2-types#256) to handle RNA data, and the current required functionality for RESCRIPt (e.g. DNA-to-RNA conversions), we should migrate some of these transformers and related content to q2-types. Slate this for the next QIIME 2 (2021.6??) and RESCRIPt releases.

@thermokarst
Copy link
Contributor

thermokarst commented Apr 21, 2021

EDIT: this was resolved in #102

This actually makes it so that it is impossible to have both q2-types and rescript installed in the same env (which is a problem, since rescript depends on q2-types):

ValueError: Duplicate semantic type ('RNASequence') defined in plugins: 'types' and 'rescript'

Unfortunately, this has caused some problems with the QIIME 2 2021.4 release - we need to train new feature classifiers in order to publish the release, but we can't train right now because rescript is uninstallable in this state. I'll take a crack at fixing this, PR coming in soon.

@nbokulich
Copy link
Collaborator

@thermokarst @mikerobeson can this issue be closed? It looks like this was resolved in #102 ... is there still a lingering transformer that needs to migrate?

@mikerobeson
Copy link
Collaborator Author

mikerobeson commented Feb 22, 2022

There are a few transformers that need to be moved over still... and utility methods here and here.

@nbokulich
Copy link
Collaborator

the first utility you linked (reverse_transcribe) is exposing the transformer as a stand-alone method and should not be moved (at least not to q2-types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants