Fix for auth customers and express pay (#108)

bold-commerce · Oct 31, 2024 · 9c6dee0 · 9c6dee0
1 parent 91c264f
commit 9c6dee0
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/Service/ExpressPay/QuoteConverter.php b/Service/ExpressPay/QuoteConverter.php
@@ -104,15 +104,22 @@ public function convertCustomer(Quote $quote): array
             return [];
         }
 
-        return [
+        $email = $billingAddress->getEmail() ?? $shippingAddress->getEmail();
+
+        $convertedQuote = [
             'order_data' => [
                 'customer' => [
                     'first_name' => $billingAddress->getFirstname() ?? '',
-                    'last_name' => $billingAddress->getLastname() ?? '',
-                    'email' => $billingAddress->getEmail() ?? $shippingAddress->getEmail() ?? ''
+                    'last_name' => $billingAddress->getLastname() ?? ''
                 ]
             ]
         ];
+
+        if ($email) {
+            $convertedQuote['order_data']['customer']['email'] = $email;
+        }
+
+        return $convertedQuote;
     }
 
     /**
@@ -192,7 +199,7 @@ static function (Rate $rate) use ($currencyCode): array {
         if ($shippingAddress->getTelephone()) {
             $convertedQuote['order_data']['shipping_address']['phone_number'] = $shippingAddress->getTelephone();
         }
-        if ($hasRequiredAddressData && $shippingAddress->hasShippingMethod()) { // @phpstan-ignore method.notFound
+        if ($hasRequiredAddressData && $shippingAddress->hasShippingMethod() && $shippingAddress->getShippingMethod() !== '') { // @phpstan-ignore method.notFound
             $convertedQuote['order_data']['selected_shipping_option'] = [
                 'id' => $shippingAddress->getShippingMethod(),
                 'label' => $shippingAddress->getShippingDescription() ?? $shippingAddress->getShippingMethod(),