Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set limit per relation and select field option #3509

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

nestordedios
Copy link
Collaborator

This PR adds a fix for a bug introduced on PR #3477(Allow setting a limit for the options displayed in relationships selects)

The limit option is now set to the general config option maximum_listing_select or 2000 by default.

If a relation or select field has the limit option defined, the limit will be set to the value of that option.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@bobdenotter bobdenotter merged commit aff7016 into master Dec 22, 2023
16 of 24 checks passed
@bobdenotter bobdenotter deleted the fix/limit-option-inconsistency branch December 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants